yihua commented on code in PR #6670:
URL: https://github.com/apache/hudi/pull/6670#discussion_r973534451


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieCompactionConfig.java:
##########
@@ -106,6 +106,12 @@ public class HoodieCompactionConfig extends HoodieConfig {
       .withDocumentation("Only if the log file size is greater than the 
threshold in bytes,"
           + " the file group will be compacted.");
 
+  public static final ConfigProperty<Long> 
COMPACTION_LOG_FILE_LENGTH_THRESHOLD = ConfigProperty
+      .key("hoodie.compaction.logfile.length.threshold")
+      .defaultValue(0L)

Review Comment:
   Got it.  That makes sense.  Then do we even need this config?  The new 
compaction strategy prioritizes the compaction of file groups with more log 
files, and should include all file groups for compaction nevertheless.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to