afilipchik commented on a change in pull request #1517: Use appropriate FS when
loading configs
URL: https://github.com/apache/incubator-hudi/pull/1517#discussion_r409206422
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -391,7 +391,9 @@ public DeltaSyncService(Config cfg, JavaSparkContext jssc,
FileSystem fs, HiveCo
ValidationUtils.checkArgument(!cfg.filterDupes || cfg.operation !=
Operation.UPSERT,
"'--filter-dupes' needs to be disabled when '--op' is 'UPSERT' to
ensure updates are not missed.");
- this.props = properties != null ? properties :
UtilHelpers.readConfig(fs, new Path(cfg.propsFilePath),
cfg.configs).getConfig();
+ this.props = properties != null ? properties : UtilHelpers.readConfig(
+ FSUtils.getFs(cfg.propsFilePath, jssc.hadoopConfiguration()),
Review comment:
I think it is already doing that:
` FileSystem fs = FSUtils.getFs(commonPropsFile,
jssc.hadoopConfiguration());`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
