nsivabalan commented on code in PR #6580:
URL: https://github.com/apache/hudi/pull/6580#discussion_r974834548
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanPlanner.java:
##########
@@ -290,9 +296,10 @@ private Pair<Boolean, List<CleanFileInfo>>
getFilesToCleanKeepingLatestCommits(S
* @return A {@link Pair} whose left is boolean indicating whether partition
itself needs to be deleted,
* and right is a list of {@link CleanFileInfo} about the files in
the partition that needs to be deleted.
*/
- private Pair<Boolean, List<CleanFileInfo>>
getFilesToCleanKeepingLatestCommits(String partitionPath, int commitsRetained,
HoodieCleaningPolicy policy) {
+ private Map<String, Pair<Boolean, List<CleanFileInfo>>>
getFilesToCleanKeepingLatestCommits(List<String> partitionPath, int
commitsRetained, HoodieCleaningPolicy policy) {
LOG.info("Cleaning " + partitionPath + ", retaining latest " +
commitsRetained + " commits. ");
List<CleanFileInfo> deletePaths = new ArrayList<>();
+ Map<String, Pair<Boolean, List<CleanFileInfo>>> map = new HashMap<>();
Review Comment:
minor. `map` -> `cleanFileInfoPerPartitionMap`
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanPlanner.java:
##########
@@ -290,9 +296,10 @@ private Pair<Boolean, List<CleanFileInfo>>
getFilesToCleanKeepingLatestCommits(S
* @return A {@link Pair} whose left is boolean indicating whether partition
itself needs to be deleted,
* and right is a list of {@link CleanFileInfo} about the files in
the partition that needs to be deleted.
*/
- private Pair<Boolean, List<CleanFileInfo>>
getFilesToCleanKeepingLatestCommits(String partitionPath, int commitsRetained,
HoodieCleaningPolicy policy) {
+ private Map<String, Pair<Boolean, List<CleanFileInfo>>>
getFilesToCleanKeepingLatestCommits(List<String> partitionPath, int
commitsRetained, HoodieCleaningPolicy policy) {
Review Comment:
minor. lets name the argument as plural. `partitionPath` -> `partitionPaths`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
