[
https://issues.apache.org/jira/browse/HUDI-4964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jian Feng updated HUDI-4964:
----------------------------
Description:
I feel like this class is a hodgepodge and is ballooning. It does not
demonstrate the benefits of configuration separation that a pluggable
architecture should bring.
if we keep wrap config.getString(ConfigKey) with a getter method such as
config.get{$ConfigKey}() in HoodieWriteConfig, basically we need to include
almost every configKey in every config(such as
HoodieClusteringConfig,HoodieHBaseIndexConfig,HoodieIndexConfig,HoodieStorageConfig
and etc) to HoodieWriteConfig
for the consistent manner and clean code purpose, I think we should inline all
the getter methods that has no logic
> Refactor HoodieWriteConfig to make sure we have a uniform and better way to
> access config value
> -----------------------------------------------------------------------------------------------
>
> Key: HUDI-4964
> URL: https://issues.apache.org/jira/browse/HUDI-4964
> Project: Apache Hudi
> Issue Type: Improvement
> Reporter: Jian Feng
> Priority: Major
>
> I feel like this class is a hodgepodge and is ballooning. It does not
> demonstrate the benefits of configuration separation that a pluggable
> architecture should bring.
> if we keep wrap config.getString(ConfigKey) with a getter method such as
> config.get{$ConfigKey}() in HoodieWriteConfig, basically we need to include
> almost every configKey in every config(such as
> HoodieClusteringConfig,HoodieHBaseIndexConfig,HoodieIndexConfig,HoodieStorageConfig
> and etc) to HoodieWriteConfig
> for the consistent manner and clean code purpose, I think we should inline
> all the getter methods that has no logic
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
