zhangyue19921010 commented on code in PR #5416: URL: https://github.com/apache/hudi/pull/5416#discussion_r989962337
########## hudi-common/src/main/java/org/apache/hudi/common/util/queue/DisruptorExecutor.java: ########## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.common.util.queue; + +import com.lmax.disruptor.dsl.Disruptor; +import org.apache.hudi.common.util.CustomizedThreadFactory; +import org.apache.hudi.common.util.Functions; +import org.apache.hudi.common.util.Option; +import org.apache.hudi.exception.HoodieException; + +import org.apache.log4j.LogManager; +import org.apache.log4j.Logger; + +import java.util.Collections; +import java.util.Iterator; +import java.util.List; +import java.util.concurrent.ExecutionException; +import java.util.concurrent.ExecutorCompletionService; +import java.util.concurrent.ExecutorService; +import java.util.concurrent.Executors; +import java.util.function.Function; +import java.util.stream.Collectors; + +public class DisruptorExecutor<I, O, E> extends HoodieExecutor<I, O, E> { + + private static final Logger LOG = LogManager.getLogger(DisruptorExecutor.class); + + // Executor service used for launching write thread. + private final ExecutorService producerExecutorService; + // Executor service used for launching read thread. + private final ExecutorService consumerExecutorService; + // Used for buffering records which is controlled by HoodieWriteConfig#WRITE_BUFFER_LIMIT_BYTES. + private final DisruptorMessageQueue<I, O> queue; + // Producers + private final List<DisruptorBasedProducer<I>> producers; + // Consumer + private final Option<BoundedInMemoryQueueConsumer<O, E>> consumer; + // pre-execute function to implement environment specific behavior before executors (producers/consumer) run + private final Runnable preExecuteRunnable; + + public DisruptorExecutor(final int bufferSize, final Iterator<I> inputItr, + BoundedInMemoryQueueConsumer<O, E> consumer, Function<I, O> transformFunction, String waitStrategy, Runnable preExecuteRunnable) { + this(bufferSize, new IteratorBasedDisruptorProducer<>(inputItr), Option.of(consumer), transformFunction, waitStrategy, preExecuteRunnable); + } + + public DisruptorExecutor(final int bufferSize, DisruptorBasedProducer<I> producer, + Option<BoundedInMemoryQueueConsumer<O, E>> consumer, final Function<I, O> transformFunction) { + this(bufferSize, producer, consumer, transformFunction, WaitStrategyFactory.DEFAULT_STRATEGY, Functions.noop()); + } + + public DisruptorExecutor(final int bufferSize, DisruptorBasedProducer<I> producer, + Option<BoundedInMemoryQueueConsumer<O, E>> consumer, final Function<I, O> transformFunction, String waitStrategy, Runnable preExecuteRunnable) { + this(bufferSize, Collections.singletonList(producer), consumer, transformFunction, waitStrategy, preExecuteRunnable); + } + + public DisruptorExecutor(final int bufferSize, List<DisruptorBasedProducer<I>> producers, + Option<BoundedInMemoryQueueConsumer<O, E>> consumer, final Function<I, O> transformFunction, + final String waitStrategy, Runnable preExecuteRunnable) { + this.producers = producers; + this.consumer = consumer; + this.preExecuteRunnable = preExecuteRunnable; + // Ensure fixed thread for each producer thread + this.producerExecutorService = Executors.newFixedThreadPool(producers.size(), new CustomizedThreadFactory("producer")); + // Ensure single thread for consumer + this.consumerExecutorService = Executors.newSingleThreadExecutor(new CustomizedThreadFactory("consumer")); + this.queue = new DisruptorMessageQueue<>(bufferSize, transformFunction, waitStrategy, producers.size(), preExecuteRunnable); + } + + /** + * Start all Producers. + */ + public ExecutorCompletionService<Boolean> startProducers() { + final ExecutorCompletionService<Boolean> completionService = + new ExecutorCompletionService<Boolean>(producerExecutorService); + producers.stream().map(producer -> { + return completionService.submit(() -> { + try { + preExecuteRunnable.run(); + + DisruptorPublisher publisher = new DisruptorPublisher<>(producer, queue); + publisher.startProduce(); + + } catch (Throwable e) { + LOG.error("error producing records", e); + throw e; + } + return true; + }); + }).collect(Collectors.toList()); + return completionService; + } + + @Override + public E execute() { + try { + assert consumer.isPresent(); + setupConsumer(); + ExecutorCompletionService<Boolean> pool = startProducers(); + + waitForProducersFinished(pool); + queue.getInnerQueue().shutdown(); + consumer.get().finish(); + + return consumer.get().getResult(); + } catch (InterruptedException ie) { + shutdownNow(); + Thread.currentThread().interrupt(); + throw new HoodieException(ie); + } catch (Exception e) { + throw new HoodieException(e); + } + } + + private void waitForProducersFinished(ExecutorCompletionService<Boolean> pool) throws InterruptedException, ExecutionException { + for (int i = 0; i < producers.size(); i++) { + pool.take().get(); Review Comment: Yeap. Just use this code to wait all the producer to complete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
