lamber-ken commented on a change in pull request #1512:
URL: https://github.com/apache/incubator-hudi/pull/1512#discussion_r413254988



##########
File path: 
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -190,6 +190,9 @@ public Operation convert(String value) throws 
ParameterException {
     @Parameter(names = {"--table-type"}, description = "Type of table. 
COPY_ON_WRITE (or) MERGE_ON_READ", required = true)
     public String tableType;
 
+    @Parameter(names = {"--table-file-format"}, description = "BaseFileFormat 
of table. PARQUET (or) ORC")

Review comment:
       Reasonable, done

##########
File path: 
hudi-utilities/src/main/java/org/apache/hudi/utilities/HDFSParquetImporter.java
##########
@@ -251,6 +252,8 @@ public void validate(String name, String value) {
     public String tableName = null;
     @Parameter(names = {"--table-type", "-tt"}, description = "Table type", 
required = true)
     public String tableType = null;
+    @Parameter(names = {"--table-file-format", "-tff"}, description = "The 
base file storage format")

Review comment:
       Reasonable, done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to