zhangyue19921010 commented on code in PR #5416: URL: https://github.com/apache/hudi/pull/5416#discussion_r996574823
########## hudi-common/src/main/java/org/apache/hudi/common/util/queue/DisruptorMessageQueue.java: ########## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.common.util.queue; + +import com.lmax.disruptor.EventTranslator; +import com.lmax.disruptor.RingBuffer; +import com.lmax.disruptor.WaitStrategy; +import com.lmax.disruptor.dsl.Disruptor; +import com.lmax.disruptor.dsl.ProducerType; +import org.apache.hudi.common.util.Option; +import org.apache.log4j.LogManager; +import org.apache.log4j.Logger; + +import java.util.function.Function; + +public class DisruptorMessageQueue<I, O> implements HoodieMessageQueue<I, O> { + + private static final Logger LOG = LogManager.getLogger(DisruptorMessageQueue.class); + + private final Disruptor<HoodieDisruptorEvent<O>> queue; + private final Function<I, O> transformFunction; + private final RingBuffer<HoodieDisruptorEvent<O>> ringBuffer; + + public DisruptorMessageQueue(int bufferSize, Function<I, O> transformFunction, String waitStrategyName, int totalProducers, Runnable preExecuteRunnable) { + WaitStrategy waitStrategy = WaitStrategyFactory.build(waitStrategyName); + HoodieDaemonThreadFactory threadFactory = new HoodieDaemonThreadFactory(preExecuteRunnable); + + this.queue = new Disruptor<>(HoodieDisruptorEvent::new, bufferSize, threadFactory, totalProducers > 1 ? ProducerType.MULTI : ProducerType.SINGLE, waitStrategy); + this.ringBuffer = queue.getRingBuffer(); + this.transformFunction = transformFunction; + } + + @Override + public long size() { + return queue.getBufferSize(); + } + + @Override + public void insertRecord(I value) throws Exception { + O applied = transformFunction.apply(value); + + EventTranslator<HoodieDisruptorEvent<O>> translator = new EventTranslator<HoodieDisruptorEvent<O>>() { + @Override + public void translateTo(HoodieDisruptorEvent<O> event, long sequence) { + event.set(applied); + } + }; + + queue.getRingBuffer().publishEvent(translator); + } + + @Override + public Option<O> readNextRecord() { + // Let DisruptorMessageHandler to handle consuming logic. + return null; + } + + @Override + public void close() { + queue.shutdown(); + } + + public void waitForConsumingFinished() throws InterruptedException { + while (!isEmpty()) { + Thread.sleep(1000); Review Comment: After refactoring, we don't need this `Consuming waiting` now. instead we will 1. Wait for all producers finished producing. 2. shutdown disruptor directly `call queue.close` which will waits until all events currently in the disruptor have been processed by all event processors 3. get and return result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
