[GitHub] [hudi] slfan1989 commented on a diff in pull request #6946: [HUDI-5027] Improve getHBaseConnection Use Constants Replace HardCode.

[GitBox]

slfan1989 commented on code in PR #6946:
URL: https://github.com/apache/hudi/pull/6946#discussion_r1000134826


##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/index/hbase/SparkHoodieHBaseIndex.java:
##########
@@ -145,22 +154,22 @@ public HBaseIndexQPSResourceAllocator 
createQPSResourceAllocator(HoodieWriteConf
   private Connection getHBaseConnection() {
     Configuration hbaseConfig = HBaseConfiguration.create();
     String quorum = config.getHbaseZkQuorum();
-    hbaseConfig.set("hbase.zookeeper.quorum", quorum);
+    hbaseConfig.set(ZOOKEEPER_QUORUM, quorum);
     String zkZnodeParent = config.getHBaseZkZnodeParent();
     if (zkZnodeParent != null) {
-      hbaseConfig.set("zookeeper.znode.parent", zkZnodeParent);
+      hbaseConfig.set(ZOOKEEPER_ZNODE_PARENT, zkZnodeParent);
     }
     String port = String.valueOf(config.getHbaseZkPort());
-    hbaseConfig.set("hbase.zookeeper.property.clientPort", port);
+    hbaseConfig.set(CLIENT_ZOOKEEPER_CLIENT_PORT, port);

Review Comment:
   @xushiyan Thank you very much for your reminder! I am looking for the 
`hbase.zookeeper.property.clientPort` parameter in the Hbase project, this 
parameter should be `ZOOKEEPER_CLIENT_PORT`
   
   
![image](https://user-images.githubusercontent.com/55643692/196857465-3d24cc67-fa9d-4905-9b1d-1f025b034e43.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org