[GitHub] [hudi] yihua commented on a diff in pull request #7006: [HUDI-5063] Enabling run time stats to be serialized with commit metadata

[GitBox]

yihua commented on code in PR #7006:
URL: https://github.com/apache/hudi/pull/7006#discussion_r1002299508


##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieWriteStat.java:
##########
@@ -163,7 +160,6 @@ public class HoodieWriteStat implements Serializable {
   private Long maxEventTime;
 
   @Nullable
-  @JsonIgnore

Review Comment:
   The only other class using `@JsonIgnore` is 
`HoodieConsistentHashingMetadata`, which looks legit.



##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieWriteStat.java:
##########
@@ -163,7 +160,6 @@ public class HoodieWriteStat implements Serializable {
   private Long maxEventTime;
 
   @Nullable
-  @JsonIgnore

Review Comment:
   Have you checked if we use `@JsonIgnore` annotation elsewhere?  We should 
avoid such a pattern.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org