xushiyan commented on code in PR #6824:
URL: https://github.com/apache/hudi/pull/6824#discussion_r1002955844
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoHoodieTableCommand.scala:
##########
@@ -160,7 +167,7 @@ case class MergeIntoHoodieTableCommand(mergeInto:
MergeIntoTable) extends Hoodie
// column order changed after left anti join , we should keep column
order of source dataframe
val cols = removeMetaFields(sourceDF).columns
- executeInsertOnly(insertSourceDF.select(cols.head, cols.tail:_*),
parameters)
+ executeInsertOnly(insertSourceDF.select(cols.head, cols.tail:_*),
writeParam)
Review Comment:
@KnightChess ok agree with the merge into semantics of doing upsert. To
improve code readability, can we actually merge `executeUpsert` and
`executeInsertOnly`? we're actually separate the condition flows within
`executeUpsert`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
