[GitHub] [hudi] xicm commented on a diff in pull request #6986: [HUDI-5047] Add partition value in HoodieLogRecordReader when hoodie.datasource.write.drop.partition.columns=true

[GitBox]

xicm commented on code in PR #6986:
URL: https://github.com/apache/hudi/pull/6986#discussion_r1007788563


##########
hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java:
##########
@@ -874,21 +887,30 @@ private static Object 
rewritePrimaryTypeWithDiffSchemaType(Object oldValue, Sche
     switch (newSchema.getType()) {
       case NULL:
       case BOOLEAN:
+        if (oldSchema.getType() == Schema.Type.STRING) {

Review Comment:
   Hi @alexeykudinkin, thanks for your suggestion very much. 
   What do you think about wrapping logFiles as PartitionedFile, just like 
basefiles?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org