[ 
https://issues.apache.org/jira/browse/HUDI-5018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629576#comment-17629576
 ] 

xi chaomin commented on HUDI-5018:
----------------------------------

Hi [~xushiyan] , I can do this improvement, but I have a question, how to tell 
the avg value is set by user or is default?

> Make user-provided copyOnWriteRecordSizeEstimate first precedence
> -----------------------------------------------------------------
>
>                 Key: HUDI-5018
>                 URL: https://issues.apache.org/jira/browse/HUDI-5018
>             Project: Apache Hudi
>          Issue Type: Improvement
>          Components: writer-core
>            Reporter: Raymond Xu
>            Assignee: Raymond Xu
>            Priority: Major
>             Fix For: 0.12.2
>
>
> For estimated avg record size
> https://hudi.apache.org/docs/configurations/#hoodiecopyonwriterecordsizeestimate
> which is used here
> https://github.com/apache/hudi/blob/86a1efbff1300603a8180111eae117c7f9dbd8a5/hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/UpsertPartitioner.java#L372
> Propose to respect user setting by following the precedence as below
> 1) if user sets a value, then use it as is 
> 2) if user not setting it, infer from timeline commit metadata 
> 3) if timeline is empty, use a default (current: 1024)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to