chenshzh commented on code in PR #7017:
URL: https://github.com/apache/hudi/pull/7017#discussion_r1015033559
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableSource.java:
##########
@@ -162,7 +163,7 @@ public HoodieTableSource(
this.limit = limit == null ? NO_LIMIT_CONSTANT : limit;
this.filters = filters == null ? Collections.emptyList() : filters;
this.hadoopConf = HadoopConfigurations.getHadoopConf(conf);
- this.metaClient = StreamerUtil.metaClientForReader(conf, hadoopConf);
+ this.metaClient =
Optional.ofNullable(metaClient).orElse(StreamerUtil.metaClientForReader(conf,
hadoopConf));
Review Comment:
> Can we just decide whether it is null directly instead of using
`Optional.ofNullable(metaClient).orElse` here ?
@danny0405 updated, pls review it one more time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
