YannByron commented on code in PR #7063: URL: https://github.com/apache/hudi/pull/7063#discussion_r1017368905
########## hudi-common/src/main/java/org/apache/hudi/common/model/HoodieRecordPayload.java: ########## @@ -116,7 +121,16 @@ default Option<IndexedRecord> combineAndGetUpdateValue(IndexedRecord currentValu */ @PublicAPIMethod(maturity = ApiMaturityLevel.STABLE) default Option<IndexedRecord> getInsertValue(Schema schema, Properties properties) throws IOException { - return getInsertValue(schema); + boolean containsDropPartColKey = properties.containsKey(HoodieTableConfig.DROP_PARTITION_COLUMNS.key()); Review Comment: is this code necessary? maybe the below line is enough. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org