[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #7052: [MINOR] Make sure Dictionary Encoding in Parquet enabled by default

Fri, 11 Nov 2022 14:06:16 -0800 


alexeykudinkin commented on code in PR #7052:
URL: https://github.com/apache/hudi/pull/7052#discussion_r1020584493


##########
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieParquetConfig.java:
##########
@@ -37,7 +37,7 @@
 
   public HoodieParquetConfig(T writeSupport, CompressionCodecName 
compressionCodecName, int blockSize,
                              int pageSize, long maxFileSize, Configuration 
hadoopConf, double compressionRatio) {
-    this(writeSupport, compressionCodecName, blockSize, pageSize, maxFileSize, 
hadoopConf, compressionRatio, false);
+    this(writeSupport, compressionCodecName, blockSize, pageSize, maxFileSize, 
hadoopConf, compressionRatio, true);

Review Comment:
   Discussed offline: there's no reason for this value not to be configured. 
Will follow-up and rebase all users of this ctor to instead rely on the 
configured value 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to