zhuanshenbsj1 opened a new pull request, #7232:
URL: https://github.com/apache/hudi/pull/7232

   ### Change Logs
   
   Related to [HUDI-5235](https://issues.apache.org/jira/browse/HUDI-5235)
   
   1. Need to add a check  between 
CLUSTERING_PLAN_STRATEGY_TARGET_FILE_MAX_BYTES and 
CLUSTERING_PLAN_STRATEGY_SMALL_FILE_LIMIT,otherwise, merged files will always 
fail to meet the clustering requirements
   
   2. Clustering Plan has check the size by 
CLUSTERING_PLAN_STRATEGY_TARGET_FILE_MAX_BYTES  already ,there is no need to 
check by PARQUET_MAX_FILE_SIZE again , Also this is a clustering operator not a 
stream writer operator.   In addition,target_size is calculated by the file 
size on hdfs(compressed ), while parquet_size calculates the size by streaming 
writes(uncompressed ). A clustering group often combines multiple files,  it 
maybe causing some unknown bugs.
   
   
   ### Impact
   
   _Describe any public API or user-facing feature change or any performance 
impact._
   
   ### Risk level (write none, low medium or high below)
   
   _If medium or high, explain what verification was done to mitigate the 
risks._
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, 
config, or user-facing change_
   
   - _The config description must be updated if new configs are added or the 
default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. 
Please create a Jira ticket, attach the
     ticket number here and follow the 
[instruction](https://hudi.apache.org/contribute/developer-setup#website) to 
make
     changes to the website._
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to