TJX2014 commented on code in PR #7220:
URL: https://github.com/apache/hudi/pull/7220#discussion_r1028963797
##########
hudi-common/src/test/java/org/apache/hudi/common/table/view/TestPriorityBasedFileSystemView.java:
##########
@@ -75,7 +75,8 @@ public class TestPriorityBasedFileSystemView {
@BeforeEach
public void setUp() {
- fsView = new PriorityBasedFileSystemView(primary, secondary);
+ fsView = new PriorityBasedFileSystemView(primary, () -> secondary);
+ fsView.getSecondaryView();
Review Comment:
Hi @xushiyan , I have added lazy test for this PR, please review again
##########
hudi-common/src/test/java/org/apache/hudi/common/table/view/TestPriorityBasedFileSystemView.java:
##########
@@ -75,7 +75,8 @@ public class TestPriorityBasedFileSystemView {
@BeforeEach
public void setUp() {
- fsView = new PriorityBasedFileSystemView(primary, secondary);
+ fsView = new PriorityBasedFileSystemView(primary, () -> secondary);
+ fsView.getSecondaryView();
Review Comment:
done
##########
hudi-common/src/test/java/org/apache/hudi/common/table/view/TestPriorityBasedFileSystemView.java:
##########
@@ -75,7 +75,8 @@ public class TestPriorityBasedFileSystemView {
@BeforeEach
public void setUp() {
- fsView = new PriorityBasedFileSystemView(primary, secondary);
+ fsView = new PriorityBasedFileSystemView(primary, () -> secondary);
+ fsView.getSecondaryView();
Review Comment:
there are many following cases use secondary directly, if not init here,
will cause issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
