[GitHub] [hudi] YannByron commented on a diff in pull request #7196: [MINOR] move logic for deleting active instant to HoodieActiveTimeline

[GitBox]

YannByron commented on code in PR #7196:
URL: https://github.com/apache/hudi/pull/7196#discussion_r1032441151


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/HoodieTimelineArchiver.java:
##########
@@ -570,12 +570,24 @@ private boolean 
deleteArchivedInstants(List<HoodieInstant> archivedInstants, Hoo
     return success;
   }
 
-  private boolean deleteArchivedInstantFiles(HoodieEngineContext context, 
boolean success, List<String> files) {
-    Map<String, Boolean> resultDeleteInstantFiles = 
deleteFilesParallelize(metaClient, files, context, false);
+  private boolean deleteArchivedInstants(HoodieEngineContext context,
+                                         HoodieTableMetaClient metaClient,
+                                         List<HoodieInstant> instants) {
+    if (instants.isEmpty()) {
+      return true;
+    }
 
-    for (Map.Entry<String, Boolean> result : 
resultDeleteInstantFiles.entrySet()) {
-      LOG.info("Archived and deleted instant file " + result.getKey() + " : " 
+ result.getValue());
-      success &= result.getValue();
+    Map<HoodieInstant, Boolean> result = context.mapToPair(
+        instants,
+        instant -> ImmutablePair.of(
+            instant,
+            metaClient.getActiveTimeline().deleteInstantFileIfExists(instant, 
false)),

Review Comment:
   I was wrong about that. I thought the original logic was the 
`ignoreFailure=false` case. Will fix this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org