CTTY commented on code in PR #6882: URL: https://github.com/apache/hudi/pull/6882#discussion_r1037609735
########## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieCreateHandle.java: ########## @@ -56,7 +56,7 @@ private static final Logger LOG = LogManager.getLogger(HoodieCreateHandle.class); protected final HoodieFileWriter<IndexedRecord> fileWriter; - protected final Path path; + protected final Path physicalPath; Review Comment: Yeah it's a little bit confusing, but `phyicalPath` here is the path to an actual file while `storageLocation` is a folder that contains files or other folders ########## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieCreateHandle.java: ########## @@ -56,7 +56,7 @@ private static final Logger LOG = LogManager.getLogger(HoodieCreateHandle.class); protected final HoodieFileWriter<IndexedRecord> fileWriter; - protected final Path path; + protected final Path physicalPath; Review Comment: Yeah it's a little bit confusing, so the `phyicalPath` here is the path to an actual file while `storageLocation` is a folder that contains files or other folders -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
