[GitHub] [hudi] codope commented on a diff in pull request #7197: [MINOR]set returnNullIfNotFound false in DefaultHoodieRecordPayload.java

Tue, 06 Dec 2022 23:14:25 -0800 


codope commented on code in PR #7197:
URL: https://github.com/apache/hudi/pull/7197#discussion_r1041836883


##########
hudi-common/src/main/java/org/apache/hudi/common/model/DefaultHoodieRecordPayload.java:
##########
@@ -132,10 +132,10 @@ protected boolean 
needUpdatingPersistedRecord(IndexedRecord currentValue,
         
KeyGeneratorOptions.KEYGENERATOR_CONSISTENT_LOGICAL_TIMESTAMP_ENABLED.defaultValue()));
     Object persistedOrderingVal = 
HoodieAvroUtils.getNestedFieldVal((GenericRecord) currentValue,
         orderField,
-        true, consistentLogicalTimestampEnabled);
+        false, consistentLogicalTimestampEnabled);

Review Comment:
   @wqwl611 Can you please file a JIRA explaining the bug and also add a test 
case to cover the scenario?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to