nsivabalan commented on code in PR #7436:
URL: https://github.com/apache/hudi/pull/7436#discussion_r1046539085


##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadata.java:
##########
@@ -379,7 +386,8 @@ private HoodieRecord<HoodieMetadataPayload> 
composeRecord(GenericRecord avroReco
   private Map<Pair<String, FileSlice>, List<String>> 
getPartitionFileSliceToKeysMapping(final String partitionName, final 
List<String> keys) {
     // Metadata is in sync till the latest completed instant on the dataset
     List<FileSlice> latestFileSlices =
-        
HoodieTableMetadataUtil.getPartitionLatestMergedFileSlices(metadataMetaClient, 
partitionName);
+        HoodieTableMetadataUtil.getPartitionLatestMergedFileSlices(

Review Comment:
   I am thinking we can cache the file slices also similar to how we cache the 
file readers. I don't see a reason for file slices to change unless there is a 
change in timeline on which case entire FileSystemView will be refreshed. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to