[GitHub] [hudi] SteNicholas commented on a diff in pull request #7405: [HUDI-5341] IncrementalCleaning consider clustering completed later

[GitBox]

SteNicholas commented on code in PR #7405:
URL: https://github.com/apache/hudi/pull/7405#discussion_r1057412716


##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieInstant.java:
##########
@@ -82,6 +85,7 @@ public HoodieInstant(FileStatus fileStatus) {
     String fileName = fileStatus.getPath().getName();
     String fileExtension = getTimelineFileExtension(fileName);
     timestamp = fileName.replace(fileExtension, "");
+    markerFileModificationTimestamp = 
Option.ofNullable(HoodieInstantTimeGenerator.parseTimeMillisToInstantTime(fileStatus.getModificationTime()));

Review Comment:
   ```suggestion
       stateModifyTime = 
Option.ofNullable(HoodieInstantTimeGenerator.formatDate(new 
Date(fileStatus.getModificationTime())));
   ```



##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieInstantTimeGenerator.java:
##########
@@ -81,6 +81,15 @@ public static String createNewInstantTime(long milliseconds) 
{
     });
   }
 
+  public static String parseTimeMillisToInstantTime(long milliseconds) {

Review Comment:
   Remove this method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org