xushiyan commented on code in PR #6732:
URL: https://github.com/apache/hudi/pull/6732#discussion_r1058454424


##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieTableServiceManagerConfig.java:
##########
@@ -0,0 +1,187 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.common.config;
+
+import org.apache.hudi.common.model.ActionType;
+
+import javax.annotation.concurrent.Immutable;
+
+import java.util.Properties;
+
+/**
+ * Configurations used by the Hudi Table Service Manager.
+ */
+@Immutable
+@ConfigClassProperty(name = "Table Service Manager Configs",
+    groupName = ConfigGroups.Names.WRITE_CLIENT,
+    description = "Configurations used by the Hudi Table Service Manager.")
+public class HoodieTableServiceManagerConfig extends HoodieConfig {
+
+  public static final String TABLE_SERVICE_MANAGER_PREFIX = 
"hoodie.table.service.manager";
+
+  public static final ConfigProperty<Boolean> TABLE_SERVICE_MANAGER_ENABLE = 
ConfigProperty
+      .key(TABLE_SERVICE_MANAGER_PREFIX + ".enable")
+      .defaultValue(false)
+      .withDocumentation("Use table manager service to execute table service");
+
+  public static final ConfigProperty<String> TABLE_SERVICE_MANAGER_URIS = 
ConfigProperty
+      .key(TABLE_SERVICE_MANAGER_PREFIX + ".uris")
+      .defaultValue("http://localhost:9091";)
+      .withDocumentation("Table service manager uris");
+
+  public static final ConfigProperty<String> TABLE_SERVICE_MANAGER_ACTIONS = 
ConfigProperty
+      .key(TABLE_SERVICE_MANAGER_PREFIX + ".actions")
+      .defaultValue("")
+      .withDocumentation("Which action deploy on table service manager such as 
compaction:clean, default null");
+
+  public static final ConfigProperty<String> 
TABLE_SERVICE_MANAGER_DEPLOY_USERNAME = ConfigProperty
+      .key(TABLE_SERVICE_MANAGER_PREFIX + ".deploy.username")
+      .defaultValue("default")
+      .withDocumentation("The user name to deploy for table service of this 
table");
+
+  public static final ConfigProperty<String> 
TABLE_SERVICE_MANAGER_DEPLOY_QUEUE = ConfigProperty
+      .key(TABLE_SERVICE_MANAGER_PREFIX + ".deploy.queue")
+      .defaultValue("default")
+      .withDocumentation("The queue to deploy for table service of this 
table");
+
+  public static final ConfigProperty<String> 
TABLE_SERVICE_MANAGER_DEPLOY_RESOURCE = ConfigProperty
+      .key(TABLE_SERVICE_MANAGER_PREFIX + ".deploy.resource")
+      .defaultValue("4g:4g")
+      .withDocumentation("The resource to deploy for table service of this 
table, default driver 4g, executor 4g");

Review Comment:
   we also support java engine. so do you agree with this pattern with engine 
prefix?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to