[GitHub] [hudi] danny0405 commented on a diff in pull request #7542: [HUDI-5469] Hive doesn't respect the space at the end of partition path, so remove it to avoid dupl…

[GitBox]

danny0405 commented on code in PR #7542:
URL: https://github.com/apache/hudi/pull/7542#discussion_r1058707319


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/keygen/KeyGenUtils.java:
##########
@@ -131,6 +131,9 @@ public static String getRecordPartitionPath(GenericRecord 
record, List<String> p
       } else {
         if (encodePartitionPath) {
           fieldVal = PartitionPathEncodeUtils.escapePathName(fieldVal);
+        } else {
+          // Hive doesn't respect the space at the end, so remove it to avoid 
duplicate keys error
+          fieldVal = fieldVal.trim();

Review Comment:
   Yeah, the fix changes the partition value which may not be what the user 
desires.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org