[GitHub] [hudi] SteNicholas commented on a diff in pull request #7568: [HUDI-5341] CleanPlanner retains earliest commits must not be later than earliest pending commit

[GitBox]

SteNicholas commented on code in PR #7568:
URL: https://github.com/apache/hudi/pull/7568#discussion_r1058910341


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/HoodieTimelineArchiver.java:
##########
@@ -432,6 +433,11 @@ private Stream<HoodieInstant> getCommitInstantsToArchive() 
{
               table.getActiveTimeline(), 
config.getInlineCompactDeltaCommitMax())
               : Option.empty();
 
+      // The clustering commit instant can not be archived unless we ensure 
that the replaced files have been cleaned,
+      // without the replaced files metadata on the timeline, the fs view 
would expose duplicates for readers.
+      Option<HoodieInstant> oldestInstantToRetainForClustering =

Review Comment:
   @leesf, refer to the naming of `oldestInstantToRetainForCompaction`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org