trushev commented on code in PR #7626:
URL: https://github.com/apache/hudi/pull/7626#discussion_r1071735088
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/HoodieFlinkWriteClient.java:
##########
@@ -94,7 +94,7 @@
* FileID to write handle mapping in order to record the write handles for
each file group,
* so that we can append the mini-batch data buffer incrementally.
*/
- private final Map<String, HoodieWriteHandle<?, ?, ?, ?>> bucketToHandles;
+ private final Map<String, MiniBatchHandle> bucketToHandles;
Review Comment:
I think you are right. There is no need to store writers because they closed
by `HoodieConsumer.finish()`. So if we have `List<WriteStatus> writeStatus`
then the writer is already closed. We should keep only one `currentWriter` to
handle exception during write operation. I'm preparing updated fix now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
