[GitHub] [hudi] nsivabalan commented on a diff in pull request #7619: [MINOR] Optimizing schema validation in Metadata table

[GitBox]

nsivabalan commented on code in PR #7619:
URL: https://github.com/apache/hudi/pull/7619#discussion_r1071792500


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java:
##########
@@ -814,18 +820,22 @@ private void validateSchema() throws 
HoodieUpsertException, HoodieInsertExceptio
   }
 
   public void validateUpsertSchema() throws HoodieUpsertException {
-    try {
-      validateSchema();
-    } catch (HoodieException e) {
-      throw new HoodieUpsertException("Failed upsert schema compatibility 
check", e);
+    if (!isMetadataTable) {
+      try {
+        validateSchema();
+      } catch (HoodieException e) {
+        throw new HoodieUpsertException("Failed upsert schema compatibility 
check", e);
+      }
     }
   }
 
   public void validateInsertSchema() throws HoodieInsertException {
-    try {
-      validateSchema();
-    } catch (HoodieException e) {
-      throw new HoodieInsertException("Failed insert schema compatibility 
check", e);
+    if (!isMetadataTable) {
+      try {
+        validateSchema();
+      } catch (HoodieException e) {
+        throw new HoodieInsertException("Failed insert schema compatibility 
check", e);
+      }
     }
   }

Review Comment:
   have added a jira to track adding a test for this 
https://issues.apache.org/jira/browse/HUDI-5566 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org