LinMingQiang commented on PR #7719:
URL: https://github.com/apache/hudi/pull/7719#issuecomment-1411533859

   > This modification adds an API method, maybe we can do it in another way. 
We can place storage descriptor modifications within the scope of the 
`org.apache.hudi.hive.HoodieHiveSyncClient#updateLastCommitTimeSynced` method.
   > 
   > This way we can avoid the modification of the api. WDYT? @LinMingQiang
   
   I don't think 
`org.apache.hudi.hive.HoodieHiveSyncClient#updateLastCommitTimeSynced` method 
is suitable for doing this,
   method `updateStorageDescriptor` is more suitable for the current logic and 
has no other impact.  WDYT?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to