beyond1920 commented on code in PR #7801:
URL: https://github.com/apache/hudi/pull/7801#discussion_r1095512397


##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/source/stats/TestExpressionEvaluator.java:
##########
@@ -103,8 +108,9 @@ void testEqualTo() {
     equalTo.bindColStats(indexRow6, queryFields(2), rExpr);
     assertFalse(equalTo.eval(), "12 <> null");
 
-    equalTo.bindVal(new ValueLiteralExpression(null, DataTypes.INT()));
-    assertFalse(equalTo.eval(), "null <> null");
+    assertThrows(
+        IllegalStateException.class,

Review Comment:
   There is a preprocessing in `bindCall` which would translate to 
`AlwaysFalse` evaluator instead of EqualsTo/NotEqualsTo/In...
   So the other evaluator could not support null val.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to