xushiyan commented on a change in pull request #1644:
URL: https://github.com/apache/incubator-hudi/pull/1644#discussion_r428757663
##########
File path:
hudi-common/src/test/java/org/apache/hudi/common/util/collection/TestRocksDBDAO.java
##########
@@ -45,7 +45,7 @@
/**
* Tests RocksDB manager {@link RocksDBDAO}.
*/
-public class TestRocksDBManager {
+public class TestRocksDBDAO {
Review comment:
@yanghua I'm trying to align it with the class under test, which is
`RocksDBDAO`. So the pattern is to prefix it with `Test`. Given that we only
have `RocksDBDAO` class not `RocksDBManager`, figuring we'd better align it
with the test name to avoid confusion. Sound good?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
