alexeykudinkin commented on code in PR #7917:
URL: https://github.com/apache/hudi/pull/7917#discussion_r1102377837
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/HoodieSparkKryoRegistrar.scala:
##########
@@ -44,12 +45,15 @@ import org.apache.spark.serializer.KryoRegistrator
* </ol>
*/
class HoodieSparkKryoRegistrar extends HoodieCommonKryoRegistrar with
KryoRegistrator {
+
override def registerClasses(kryo: Kryo): Unit = {
///////////////////////////////////////////////////////////////////////////
// NOTE: DO NOT REORDER REGISTRATIONS
///////////////////////////////////////////////////////////////////////////
super[HoodieCommonKryoRegistrar].registerClasses(kryo)
+ kryo.register(classOf[HoodieKey], new HoodieKeySerializer)
Review Comment:
@codope correct. This is still needed to make sure we're not shuffling
fully-qualified class names in the payload
@vinothchandar correct. This registrar is only used on Spark's instance of
Kryo used for shuffling
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieDeleteBlock.java:
##########
@@ -97,6 +97,7 @@ public DeleteRecord[] getRecordsToDelete() {
}
}
+ // TODO(HUDI-5760) avoid using Kryo for serialization here
Review Comment:
Good point. Duplicated this comment in both ser/de paths
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
