danny0405 commented on code in PR #7752: URL: https://github.com/apache/hudi/pull/7752#discussion_r1105619086
########## hudi-common/src/main/java/org/apache/hudi/common/util/ClosableIterator.java: ########## @@ -24,8 +24,29 @@ * An iterator that give a chance to release resources. * * @param <R> The return type + * + * TODO move under common.util.collection */ Review Comment: Not a big fan of `TODO`s, people rarely pay attention and fix it, just my personal opinion, either fix it in this PR or create a JIRA issue to track it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
