danny0405 commented on PR #8139: URL: https://github.com/apache/hudi/pull/8139#issuecomment-1461676523
> > We try to close the hive meta sync connection after each meta sync, does that logic still work after your change? > > We don't close `HiveClient`(it lives with the lifetime of the job), we will close SyncTool's metaClient(syncing the metadata after writing operation). > > So this pr tries to reuse `HiveClient` which Spark created before when creating table(I notice that drop table already reuse spark's). It won't change the behavior for the insert operation. Got it, is it possible we can write some tests here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
