danny0405 commented on code in PR #8227: URL: https://github.com/apache/hudi/pull/8227#discussion_r1141566770
########## hudi-utilities/src/main/java/org/apache/hudi/utilities/callback/kafka/HoodieWriteCommitKafkaCallback.java: ########## @@ -85,10 +85,10 @@ public KafkaProducer<String, String> createProducer(HoodieConfig hoodieConfig) { kafkaProducerProps.setProperty(ProducerConfig.BOOTSTRAP_SERVERS_CONFIG, bootstrapServers); // default "all" to ensure no message loss kafkaProducerProps.setProperty(ProducerConfig.ACKS_CONFIG, hoodieConfig - .getString(ACKS)); + .getStringOrDefault(ACKS)); // retries 3 times by default kafkaProducerProps.setProperty(ProducerConfig.RETRIES_CONFIG, hoodieConfig - .getString(RETRIES)); + .getStringOrDefault(RETRIES)); Review Comment: Does the default val work as expected? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org