leesf commented on a change in pull request #1592:
URL: https://github.com/apache/hudi/pull/1592#discussion_r432820528
##########
File path:
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/HoodieParquetRealtimeInputFormat.java
##########
@@ -199,9 +110,9 @@ private static Configuration
addProjectionField(Configuration conf, String field
private static void addRequiredProjectionFields(Configuration configuration)
{
// Need this to do merge records in HoodieRealtimeRecordReader
- addProjectionField(configuration, HoodieRecord.RECORD_KEY_METADATA_FIELD,
HOODIE_RECORD_KEY_COL_POS);
- addProjectionField(configuration, HoodieRecord.COMMIT_TIME_METADATA_FIELD,
HOODIE_COMMIT_TIME_COL_POS);
- addProjectionField(configuration,
HoodieRecord.PARTITION_PATH_METADATA_FIELD, HOODIE_PARTITION_PATH_COL_POS);
+ addProjectionField(configuration, HoodieRecord.RECORD_KEY_METADATA_FIELD,
HoodieRealtimeInputFormatUtils.HOODIE_RECORD_KEY_COL_POS);
+ addProjectionField(configuration, HoodieRecord.COMMIT_TIME_METADATA_FIELD,
HoodieRealtimeInputFormatUtils.HOODIE_COMMIT_TIME_COL_POS);
+ addProjectionField(configuration,
HoodieRecord.PARTITION_PATH_METADATA_FIELD,
HoodieRealtimeInputFormatUtils.HOODIE_PARTITION_PATH_COL_POS);
Review comment:
Does it more proper to a new Constant class to hold constants in
HoodieRealtimeInputFormatUtils and HoodieRealtimeRecordReaderUtils, wdyt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
