huangxiaopingRD commented on code in PR #8351:
URL: https://github.com/apache/hudi/pull/8351#discussion_r1155518606
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/RunBootstrapProcedure.scala:
##########
@@ -85,6 +85,7 @@ class RunBootstrapProcedure extends BaseProcedure with
ProcedureBuilder with Log
val propsFilePath = getArgValueOrDefault(args,
PARAMETERS(15)).get.asInstanceOf[String]
val bootstrapOverwrite = getArgValueOrDefault(args,
PARAMETERS(16)).get.asInstanceOf[Boolean]
+ val (tableName, database) =
HoodieCLIUtils.getHoodieDatabaseAndTable(table.get.asInstanceOf[String])
val configs: util.List[String] = new util.ArrayList[String]
Review Comment:
Yes, it would be nice if the database name was a separate parameter.
However, other existing procedures allow the table name to contain the database
name, so I choose to keep this PR change consistent with the existing logic.
For example:
https://github.com/apache/hudi/blob/master/hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieCLIUtils.scala#L62
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
