[GitHub] [hudi] lokeshj1703 commented on a diff in pull request #8480: [HUDI-6090] Optimise payload size for list of FileGroupDTO

[via GitHub]

lokeshj1703 commented on code in PR #8480:
URL: https://github.com/apache/hudi/pull/8480#discussion_r1174827172


##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/dto/FileGroupDTO.java:
##########
@@ -46,17 +48,28 @@ public class FileGroupDTO {
   TimelineDTO timeline;
 
   public static FileGroupDTO fromFileGroup(HoodieFileGroup fileGroup) {
+    return fromFileGroup(fileGroup, true);
+  }
+
+  public static HoodieFileGroup toFileGroup(FileGroupDTO dto, 
HoodieTableMetaClient metaClient) {
+    return toFileGroup(dto, metaClient, Option.empty());
+  }
+
+  public static FileGroupDTO fromFileGroup(HoodieFileGroup fileGroup, boolean 
includeTimeline) {
     FileGroupDTO dto = new FileGroupDTO();
     dto.partition = fileGroup.getPartitionPath();
     dto.id = fileGroup.getFileGroupId().getFileId();
     dto.slices = 
fileGroup.getAllRawFileSlices().map(FileSliceDTO::fromFileSlice).collect(Collectors.toList());
-    dto.timeline = TimelineDTO.fromTimeline(fileGroup.getTimeline());
+    if (includeTimeline) {
+      dto.timeline = TimelineDTO.fromTimeline(fileGroup.getTimeline());
+    }
     return dto;
   }
 
-  public static HoodieFileGroup toFileGroup(FileGroupDTO dto, 
HoodieTableMetaClient metaClient) {
+  public static HoodieFileGroup toFileGroup(FileGroupDTO dto, 
HoodieTableMetaClient metaClient, Option<HoodieTimeline> inputTimeline) {
+    HoodieTimeline fgTimeline = inputTimeline.isPresent() ? 
inputTimeline.get() : TimelineDTO.toTimeline(dto.timeline, metaClient);
     HoodieFileGroup fileGroup =

Review Comment:
   Addressed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org