PrabhuJoseph commented on code in PR #8512:
URL: https://github.com/apache/hudi/pull/8512#discussion_r1175582627
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bulk/sort/SortOperator.java:
##########
@@ -89,7 +95,7 @@ public void open() throws Exception {
binarySerializer,
computer,
comparator,
- getContainingTask().getJobConfiguration());
+ conf);
Review Comment:
Yes right, the config needs to be set in flink-conf.yaml or SqlClient
session.
https://nightlies.apache.org/flink/flink-docs-master/docs/dev/table/config/
Both Context.getConfiguration and the configuration used above are the same
Flink Configuration (flink-conf.yaml) with the table options. The later needs
less code changes, at below classes to pass the configuration object
```
Pipelines#bulkInsert -> SortOperatorGen#createSortOperator ->
SortOperator#init
```
whereas former needs changes at below classes to pass the
Context.getConfiguration
```
HoodieTableSink#getSinkRuntimeProvider -> Pipelines#bulkInsert ->
SortOperatorGen#createSortOperator -> SortOperator#init
```
> should we use that configuration then?
I think not required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
