danny0405 commented on code in PR #8505:
URL: https://github.com/apache/hudi/pull/8505#discussion_r1177650137


##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieCompactor.java:
##########
@@ -269,6 +269,7 @@ private int doCompact(JavaSparkContext jsc) throws 
Exception {
         }
       }
       HoodieWriteMetadata<JavaRDD<WriteStatus>> compactionMetadata = 
client.compact(cfg.compactionInstantTime);
+      cleanAfterCompact(client);
       return 
UtilHelpers.handleErrors(compactionMetadata.getCommitMetadata().get(), 
cfg.compactionInstantTime);

Review Comment:
   Can we just execite a synchoronous cleaning for the offline compaction and 
clustering, it does not make sense to make the cleaning async because the whole 
job in executed as a batch.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to