rohan-uptycs commented on code in PR #8503:
URL: https://github.com/apache/hudi/pull/8503#discussion_r1186717343


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndex.java:
##########
@@ -154,6 +154,14 @@ public boolean requiresTagging(WriteOperationType 
operationType) {
   public void close() {
   }
 
+  /***
+   * Updates index metadata of the given table and instant if needed.
+   * @param table The committed table.
+   * @param hoodieInstant The instant to commit.
+   */
+  public void commitIndexMetadataIfNeeded(HoodieTable table, String 
hoodieInstant) {
+  }
+

Review Comment:
   One thing we can do if we don't want to use CommitIndexMetadta interface is 
to let loadMetadta function create commit marker file , when reader ask for 
updated metadata, Commit marker recovery function(recommitMetadataFile) will 
decide if this metadata file is latest or not and create marker file if it is 
latest.
   
   Only cost of this will be listing all filegroups for that partition and 
comparing against metadata file. this will be done only once when commit file 
is not present.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to