yihua commented on code in PR #8658:
URL: https://github.com/apache/hudi/pull/8658#discussion_r1186932947
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/transaction/TestInProcessLockProvider.java:
##########
@@ -52,6 +54,107 @@ public TestInProcessLockProvider() {
lockConfiguration2 = new LockConfiguration(properties);
}
+ @Test
+ public void testLockIdentity() throws InterruptedException {
+ // The lifecycle of an InProcessLockProvider should not affect the
singleton lock
+ // for a single table, i.e., all three writers should hold the same
underlying lock instance
+ // on the same table.
+ // Writer 1: lock |----------------| unlock and close
+ // Writer 2: try lock | ... lock |------| unlock and close
+ // Writer 3: try lock | ... lock |------|
unlock and close
+ List<InProcessLockProvider> lockProviderList = new ArrayList<>();
+ InProcessLockProvider lockProvider1 = new
InProcessLockProvider(lockConfiguration1, hadoopConfiguration);
+ lockProviderList.add(lockProvider1);
+ AtomicBoolean writer2Locked = new AtomicBoolean(false);
+ AtomicBoolean writer1Completed = new AtomicBoolean(false);
+ AtomicBoolean writer2Completed = new AtomicBoolean(false);
+ AtomicBoolean writer3Completed = new AtomicBoolean(false);
+
+ // Writer 1
+ assertDoesNotThrow(() -> {
+ LOG.info("Writer 1 tries to acquire the lock.");
+ lockProvider1.lock();
+ LOG.info("Writer 1 acquires the lock.");
+ });
+ // Writer 2 thread in parallel, should block
+ // and later acquire the lock once it is released
+ Thread writer2 = new Thread(() -> {
+ InProcessLockProvider lockProvider2 = new
InProcessLockProvider(lockConfiguration1, hadoopConfiguration);
+ lockProviderList.add(lockProvider2);
+ assertDoesNotThrow(() -> {
+ LOG.info("Writer 2 tries to acquire the lock.");
+ lockProvider2.lock();
+ LOG.info("Writer 2 acquires the lock.");
Review Comment:
This is not necessary, as covered by other tests. We only need to add
additional validation for Writer 3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
