danny0405 commented on PR #8107: URL: https://github.com/apache/hudi/pull/8107#issuecomment-1537657119
Looks good! It is great if we can move the decision ` !props.containsKey(KeyGeneratorOptions.RECORDKEY_FIELD_NAME.key()) into a tool method in KeyGenUtils.autoGenerateRecordKeys(TypedProperties props) , the benefit is if someday we wanna change the keyless precondition, only one modification can do the trick. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
