[GitHub] [hudi] huangxiaopingRD commented on a diff in pull request #8660: [MINOR] Fix RunBootstrapProcedure doesn't has database default value

[via GitHub]

huangxiaopingRD commented on code in PR #8660:
URL: https://github.com/apache/hudi/pull/8660#discussion_r1187363745


##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/RunBootstrapProcedure.scala:
##########
@@ -110,9 +111,7 @@ class RunBootstrapProcedure extends BaseProcedure with 
ProcedureBuilder with Log
 
     val cfg = new BootstrapExecutorUtils.Config()
     cfg.setTableName(tableName)
-    if (database.isDefined) {
-      cfg.setDatabase(database.get)
-    }
+    cfg.setDatabase(database.getOrElse(HIVE_DATABASE.defaultValue()))
     cfg.setTableType(tableType)

Review Comment:
   yes, we can get the current database by 
`sparkSession.sessionState.catalog.getCurrentDatabase`. Do we need to change to 
that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org