weimingdiit commented on code in PR #8301:
URL: https://github.com/apache/hudi/pull/8301#discussion_r1191865864


##########
hudi-sync/hudi-sync-common/src/main/java/org/apache/hudi/sync/common/HoodieSyncConfig.java:
##########
@@ -163,6 +163,11 @@ public class HoodieSyncConfig extends HoodieConfig {
       .defaultValue("")
       .withDocumentation("The spark version used when syncing with a 
metastore.");
 
+  public static final ConfigProperty<String> META_SYNC_PARTITION_FIXMODE = 
ConfigProperty
+      .key("hoodie.datasource.hive_sync.partition_fixmode")
+      .defaultValue("false")
+      .withDocumentation("Implement a full partition sync operation when 
partitions are lost.");

Review Comment:
   @yihua @danny0405 
   Maybe I didn't describe it clearly. The purpose of this pr is to provide a 
tool parameter to control whether a full partition synchronization alignment 
operation is required when the metadata of the synchronization partition is 
found to be lost.
   
   Looking at the current code logic is to do incremental synchronization 
according to lastCommitTimeSynced. If set to true, according to the code, the 
syncAllPartitions method will be used every time to synchronize all partitions, 
which is unnecessary.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to