garyli1019 commented on a change in pull request #1722: URL: https://github.com/apache/hudi/pull/1722#discussion_r438266305
########## File path: hudi-spark/src/main/scala/org/apache/hudi/RealtimeRelation.scala ########## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi + +import org.apache.hudi.avro.HoodieAvroUtils +import org.apache.hudi.common.table.{HoodieTableMetaClient, TableSchemaResolver} +import org.apache.hudi.config.HoodieWriteConfig +import org.apache.hudi.hadoop.{HoodieParquetInputFormat, HoodieROTablePathFilter} +import org.apache.hudi.hadoop.utils.HoodieRealtimeInputFormatUtils +import org.apache.hudi.exception.HoodieException +import org.apache.hudi.table.HoodieTable +import org.apache.hadoop.mapred.JobConf +import org.apache.log4j.LogManager +import org.apache.spark.rdd.RDD +import org.apache.spark.sql.{Row, SQLContext} +import org.apache.spark.sql.sources.{BaseRelation, TableScan} +import org.apache.spark.sql.types.StructType + +import java.util +import scala.collection.JavaConverters._ + +/** + * This is the Spark DataSourceV1 relation to read Hudi MOR table. + * @param sqlContext + * @param basePath + * @param optParams + * @param userSchema + */ +class RealtimeRelation(val sqlContext: SQLContext, + val basePath: String, + val optParams: Map[String, String], + val userSchema: StructType) extends BaseRelation with TableScan { + + private val log = LogManager.getLogger(classOf[RealtimeRelation]) + private val conf = sqlContext.sparkContext.hadoopConfiguration + + // Set config for listStatus() in HoodieParquetInputFormat + conf.setClass( + "mapreduce.input.pathFilter.class", + classOf[HoodieROTablePathFilter], + classOf[org.apache.hadoop.fs.PathFilter]) + conf.setStrings("mapreduce.input.fileinputformat.inputdir", basePath) + conf.setStrings("mapreduce.input.fileinputformat.input.dir.recursive", "true") + + private val HoodieInputFormat = new HoodieParquetInputFormat + HoodieInputFormat.setConf(conf) + private val fileStatus = HoodieInputFormat.listStatus(new JobConf(conf)) + log.debug("All parquet files" + fileStatus.map(s => s.getPath.toString).mkString(",")) + private val fileGroup = HoodieRealtimeInputFormatUtils.groupLogsByBaseFile(conf, util.Arrays.stream(fileStatus)).asScala + + // Split the file group to: parquet file without a matching log file, parquet file need to merge with log files + private val parquetWithoutLogPaths: List[String] = fileGroup.filter(p => p._2.size() == 0).keys.toList + private val fileWithLogMap: Map[String, String] = fileGroup.filter(p => p._2.size() > 0).map{ case(k, v) => (k, v.asScala.toList.mkString(","))}.toMap + log.debug("ParquetWithoutLogPaths" + parquetWithoutLogPaths.mkString(",")) + log.debug("ParquetWithLogPaths" + fileWithLogMap.map(m => s"${m._1}:${m._2}").mkString(",")) + + // Add log file map to options + private val finalOps = optParams ++ fileWithLogMap + + // Load Hudi metadata + val metaClient = new HoodieTableMetaClient(conf, basePath, true) + private val hoodieTable = HoodieTable.create(metaClient, HoodieWriteConfig.newBuilder().withPath(basePath).build(), conf) + + private val commitTimeline = hoodieTable.getMetaClient.getCommitsAndCompactionTimeline + if (commitTimeline.empty()) { + throw new HoodieException("No Valid Hudi timeline exists") + } + private val completedCommitTimeline = hoodieTable.getMetaClient.getCommitsTimeline.filterCompletedInstants() + private val lastInstant = completedCommitTimeline.lastInstant().get() + conf.setStrings("hoodie.realtime.last.commit", lastInstant.getTimestamp) + + // use schema from latest metadata, if not present, read schema from the data file + private val latestSchema = { + val schemaUtil = new TableSchemaResolver(metaClient) + val tableSchema = HoodieAvroUtils.createHoodieWriteSchema(schemaUtil.getTableAvroSchemaWithoutMetadataFields); + AvroConversionUtils.convertAvroSchemaToStructType(tableSchema) + } + + override def schema: StructType = latestSchema + + override def buildScan(): RDD[Row] = { + // Read parquet file doesn't have matching log file to merge as normal parquet + val regularParquet = sqlContext + .read + .options(finalOps) + .schema(schema) + .format("parquet") + .load(parquetWithoutLogPaths:_*) + .toDF() + // Hudi parquet files needed to merge with log file + sqlContext + .read + .options(finalOps) + .schema(schema) + .format("org.apache.spark.sql.execution.datasources.parquet.HoodieRealtimeInputFormat") + .load(fileWithLogMap.keys.toList:_*) + .toDF() + .union(regularParquet) + .rdd Review comment: I think it would be the same. The interface requires rdd here. We have done this in incrementalRelation as well. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
