danny0405 commented on code in PR #8687:
URL: https://github.com/apache/hudi/pull/8687#discussion_r1200440995
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/SparkHoodieTableFileIndex.scala:
##########
@@ -319,6 +319,8 @@ class SparkHoodieTableFileIndex(spark: SparkSession,
* @return relative partition path and a flag to indicate if the path is
complete (i.e., not a prefix)
*/
private def
composeRelativePartitionPath(staticPartitionColumnNameValuePairs: Seq[(String,
(String, Any))]): String = {
+ // NOTE: Do not blindly use default value if tableConfig does not have the
hiveStylePartitioningEnable config
+ checkState(metaClient.getTableConfig.getHiveStylePartitioningEnableOrNull
!= null)
Review Comment:
Having a default value is okay, what we need to do is to unify the entrence
of all the table config initialization. The hive style partitioning is a
definitive table config option, let's fix the initialization of it instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
