jonvex commented on code in PR #8638: URL: https://github.com/apache/hudi/pull/8638#discussion_r1202697891
########## hudi-utilities/src/main/java/org/apache/hudi/utilities/schema/RowBasedSchemaProvider.java: ########## @@ -44,7 +45,12 @@ public RowBasedSchemaProvider(StructType rowStruct) { @Override public Schema getSourceSchema() { - return AvroConversionUtils.convertStructTypeToAvroSchema(rowStruct, HOODIE_RECORD_STRUCT_NAME, - HOODIE_RECORD_NAMESPACE); + try { + return AvroConversionUtils.convertStructTypeToAvroSchema(rowStruct, HOODIE_RECORD_STRUCT_NAME, + HOODIE_RECORD_NAMESPACE); + } catch (Exception e) { + throw new HoodieSchemaException("Failed to convert struct type to avro schema", e); Review Comment: Good catch. I actually do throw it in there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org