This is an automated email from the ASF dual-hosted git repository.

yihua pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hudi.git


The following commit(s) were added to refs/heads/master by this push:
     new 29bca0085f3 [MINOR] Fix some typos and delete unused parameter (#8642)
29bca0085f3 is described below

commit 29bca0085f332e1089197af3fda8d804bd495ec0
Author: Brisk Wong <2367785...@qq.com>
AuthorDate: Wed May 24 05:06:36 2023 +0800

    [MINOR] Fix some typos and delete unused parameter (#8642)
---
 .../hudi/common/table/view/AbstractTableFileSystemView.java    |  2 +-
 .../hudi/common/table/view/HoodieTableFileSystemView.java      |  2 +-
 .../table/view/IncrementalTimelineSyncFileSystemView.java      | 10 ++++------
 3 files changed, 6 insertions(+), 8 deletions(-)

diff --git 
a/hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java
 
b/hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java
index 0279be560aa..0ed7acc9709 100644
--- 
a/hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java
+++ 
b/hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java
@@ -486,7 +486,7 @@ public abstract class AbstractTableFileSystemView 
implements SyncableFileSystemV
   /**
    * Helper to convert file-status to log-files.
    *
-   * @param statuses List of FIle-Status
+   * @param statuses List of File-Status
    */
   private Stream<HoodieLogFile> convertFileStatusesToLogFiles(FileStatus[] 
statuses) {
     Predicate<FileStatus> rtFilePredicate = fileStatus ->  {
diff --git 
a/hudi-common/src/main/java/org/apache/hudi/common/table/view/HoodieTableFileSystemView.java
 
b/hudi-common/src/main/java/org/apache/hudi/common/table/view/HoodieTableFileSystemView.java
index eb23c1ca1c1..a29c89edc87 100644
--- 
a/hudi-common/src/main/java/org/apache/hudi/common/table/view/HoodieTableFileSystemView.java
+++ 
b/hudi-common/src/main/java/org/apache/hudi/common/table/view/HoodieTableFileSystemView.java
@@ -63,7 +63,7 @@ public class HoodieTableFileSystemView extends 
IncrementalTimelineSyncFileSystem
   protected Map<HoodieFileGroupId, Pair<String, CompactionOperation>> 
fgIdToPendingCompaction;
 
   /**
-   * PartitionPath + File-Id to pending compaction instant time.
+   * PartitionPath + File-Id to pending logcompaction instant time.
    */
   protected Map<HoodieFileGroupId, Pair<String, CompactionOperation>> 
fgIdToPendingLogCompaction;
 
diff --git 
a/hudi-common/src/main/java/org/apache/hudi/common/table/view/IncrementalTimelineSyncFileSystemView.java
 
b/hudi-common/src/main/java/org/apache/hudi/common/table/view/IncrementalTimelineSyncFileSystemView.java
index d8d6644ea27..3517e2218b6 100644
--- 
a/hudi-common/src/main/java/org/apache/hudi/common/table/view/IncrementalTimelineSyncFileSystemView.java
+++ 
b/hudi-common/src/main/java/org/apache/hudi/common/table/view/IncrementalTimelineSyncFileSystemView.java
@@ -123,7 +123,7 @@ public abstract class IncrementalTimelineSyncFileSystemView 
extends AbstractTabl
     // First remove pending compaction instants which were completed
     diffResult.getFinishedCompactionInstants().stream().forEach(instant -> {
       try {
-        removePendingCompactionInstant(timeline, instant);
+        removePendingCompactionInstant(instant);
       } catch (IOException e) {
         throw new HoodieException(e);
       }
@@ -132,7 +132,7 @@ public abstract class IncrementalTimelineSyncFileSystemView 
extends AbstractTabl
     // Now remove pending log compaction instants which were completed or 
removed
     
diffResult.getFinishedOrRemovedLogCompactionInstants().stream().forEach(instant 
-> {
       try {
-        removePendingLogCompactionInstant(timeline, instant);
+        removePendingLogCompactionInstant(instant);
       } catch (IOException e) {
         throw new HoodieException(e);
       }
@@ -170,10 +170,9 @@ public abstract class 
IncrementalTimelineSyncFileSystemView extends AbstractTabl
   /**
    * Remove Pending compaction instant.
    *
-   * @param timeline New Hoodie Timeline
    * @param instant Compaction Instant to be removed
    */
-  private void removePendingCompactionInstant(HoodieTimeline timeline, 
HoodieInstant instant) throws IOException {
+  private void removePendingCompactionInstant(HoodieInstant instant) throws 
IOException {
     LOG.info("Removing completed compaction instant (" + instant + ")");
     HoodieCompactionPlan plan = CompactionUtils.getCompactionPlan(metaClient, 
instant.getTimestamp());
     
removePendingCompactionOperations(CompactionUtils.getPendingCompactionOperations(instant,
 plan)
@@ -185,10 +184,9 @@ public abstract class 
IncrementalTimelineSyncFileSystemView extends AbstractTabl
    * Remove Pending compaction instant. This is called when logcompaction is 
converted to delta commit,
    * so you no longer need to track them as pending.
    *
-   * @param timeline New Hoodie Timeline
    * @param instant Log Compaction Instant to be removed
    */
-  private void removePendingLogCompactionInstant(HoodieTimeline timeline, 
HoodieInstant instant) throws IOException {
+  private void removePendingLogCompactionInstant(HoodieInstant instant) throws 
IOException {
     LOG.info("Removing completed log compaction instant (" + instant + ")");
     HoodieCompactionPlan plan = 
CompactionUtils.getLogCompactionPlan(metaClient, instant.getTimestamp());
     
removePendingLogCompactionOperations(CompactionUtils.getPendingCompactionOperations(instant,
 plan)

Reply via email to