[GitHub] [hudi] prashantwason commented on a diff in pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.

[via GitHub]

prashantwason commented on code in PR #8724:
URL: https://github.com/apache/hudi/pull/8724#discussion_r1203470106


##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java:
##########
@@ -310,12 +312,16 @@ private static Properties 
getOrderedPropertiesWithTableChecksum(Properties props
    */
   private static String storeProperties(Properties props, FSDataOutputStream 
outputStream) throws IOException {
     final String checksum;
-    if (isValidChecksum(props)) {
+    final boolean isValidChecksum = isValidChecksum(props);
+    final String comment = String.format("Date=%s, host=%s, #properties=%d, 
hudi_version=%s",
+        Instant.now(), NetworkUtils.getHostname(), isValidChecksum ? 
props.size() : props.size() + 1, HoodieVersion.get());

Review Comment:
   NetworkUtils.getHostname() does not return hostname - it returns IP address. 
So this is a fix.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org