boneanxs commented on code in PR #8452: URL: https://github.com/apache/hudi/pull/8452#discussion_r1220712391
########## hudi-common/src/main/java/org/apache/hudi/metadata/AbstractHoodieTableMetadata.java: ########## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.metadata; + +import org.apache.hudi.common.config.SerializableConfiguration; +import org.apache.hudi.common.engine.HoodieEngineContext; +import org.apache.hudi.common.fs.FSUtils; +import org.apache.hudi.common.table.HoodieTableConfig; +import org.apache.hudi.common.table.HoodieTableMetaClient; +import org.apache.hudi.common.util.PartitionPathEncodeUtils; +import org.apache.hudi.common.util.StringUtils; +import org.apache.hudi.exception.TableNotFoundException; +import org.apache.hudi.expression.ArrayData; +import org.apache.hudi.hadoop.CachingPath; +import org.apache.hudi.hadoop.SerializablePath; +import org.apache.hudi.internal.schema.Types; +import org.apache.hudi.internal.schema.utils.Conversions; + +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.Path; + +import java.util.Collections; +import java.util.List; +import java.util.stream.Collectors; +import java.util.stream.IntStream; + +public abstract class AbstractHoodieTableMetadata implements HoodieTableMetadata { + + protected final transient HoodieEngineContext engineContext; + + protected final SerializableConfiguration hadoopConf; + protected final SerializablePath dataBasePath; + + protected final boolean hiveStylePartitioningEnabled; + protected final boolean urlEncodePartitioningEnabled; + + // TODO get this from HoodieConfig + protected final boolean caseSensitive = false; + + public AbstractHoodieTableMetadata(HoodieEngineContext engineContext, SerializableConfiguration conf, String dataBasePath) { + this.engineContext = engineContext; + this.hadoopConf = conf; + this.dataBasePath = new SerializablePath(new CachingPath(dataBasePath)); + FileSystem fs = FSUtils.getFs(dataBasePath, conf.get()); + Path metaPath = new Path(dataBasePath, HoodieTableMetaClient.METAFOLDER_NAME); + TableNotFoundException.checkTableValidity(fs, this.dataBasePath.get(), metaPath); + HoodieTableConfig tableConfig = new HoodieTableConfig(fs, metaPath.toString(), null, null); Review Comment: @bvaradar I found that `FileSystemBackedTableMetadata` is hotly used in many codes, so creating metaClient to get TableConfig could badly affect the performance(Making tests timeout).  So I change here to create TableConfig directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
